search

OrangeIguanas / Bangazon-cli

0 stars 0 forks source link

order id and set to true #35

Closed abbyfleming closed 7 years ago

abbyfleming commented 7 years ago

Description

Cleaned up code, added in a CustomerOrder table with methods to get the id, and set the order to complete

Related Ticket(s)

33 #8

Testing

Testing is based off of Suzy being the only customer with one order and payment type. Because there are tests that test for True/False, it might be worthwhile to do the tests one at a time.

[X ] There are new unit tests in this PR, and I verify that there is full coverage of all new code. [X] I certify that all existing tests pass

Documentation

[X] There is new documentation in this pull request that must be reviewed..

Deploy Notes

Notes regarding deployment the contained body of work. These should note any db migrations, etc.

git pull --prune
git checkout amCreateOrder

Steps to Test

Outline the steps to test the code in this pull request.

  1. run testOrder.py commenting out tests one at a time
  2. Review Customers.py as a few clean up changes were made.

Questions

order_is_complete will need to be expanded. Perhaps query by customer id AND if the order is set to FALSE.

Let me know if you have any questions. I'm planning to walk through this in the morning (2/14). 😪

peterStaggs commented 7 years ago

🚀

ZacharyCline commented 7 years ago

🚀 pair Programming. Positional Arguments are only change needed