Thoughts? League theme.

[Arxarius]

https://imgur.com/mYowylR

Would be cool to have a league theme for the app.

[OrangeNote]

That's actually what I originally planned. But then it become a low priority feature and I ended up releasing it with the default semantic-ui theme. Now I don't know what to do because there's a PR #22 for Dark Mode. I liked the idea of having a switch for light/dark mode. Maybe we could merge the two things and make a Dark mode AND a Light mode with custom lol theme. How does it sound?

[OrangeNote]

Oh and btw your preview is awesome!

[Arxarius]

That sounds awesome, mine was just with the inspector i would need to code it up on my fork and do a pull request. Could even implement a settings function to change the theme along with other aspects.

[clabby]

I'd be glad to alter #22 with a LoL themed dark mode rather than a simple inverted color scheme. If you're (@Arxarius) already on this let me know!

[OrangeNote]

For themes we could use the same (or similar) color schemes from Nexus site (reference, switch the theme to notice that a lot of colors don't change when you switch from one to another).

[Arxarius]

sounds good, would be better to do a proper style structure and automate the build with grunt etc, I can get the basics in if you want and then we can start building themes?

[OrangeNote]

Until now I used the CSS-only version of Semantic UI, but if we wish to make themes, we should consider the standard Semantic UI package with LESS support and Gulp for building, I think.

[clabby]

Less is the way to go, I’ll get working on a non-binary theme framework tonight.

_{Sent with GitHawk}

[Arxarius]

you can keep the standard semantic as it is, building a proper scss structure for our own components is best, less is outdated.

[clabby]

@Arxarius I prefer less, but definitely open to scss, so we’ll do that. Should we add support for 3rd party themes?

_{Sent with GitHawk}

[Arxarius]

The structure for sass is the same just slight syntax changes and more control. Semantic covers most 3rd party libraries and i can build anythign you ask tbh so we can keep it to our own stuff, i will start a structure now and we can go from there.

[OrangeNote]

lol I'm not an expert in CSS and preprocessors so you should decide what's better for everyone.

I don't think we need support for custom theming, I think that's out of scope.

[Arxarius]

Agreed

[Arxarius]

@OrangeNote pull request #28 has been created.

[Arxarius]

I have also made more progress on the dark theme @ my fork

[clabby]

Added Grunt/SASS in my fork.