OrangeNote
commented
6 years ago So actually I merged this, but I had to do it locally and so it doesn't appear here. I'm still new to git features like merges 🙄
Closed deancherif closed 6 years ago
OrangeNote
commented
6 years ago So actually I merged this, but I had to do it locally and so it doesn't appear here. I'm still new to git features like merges 🙄
Hey ! I added a KoreanBuilds plugin but i had to make some changes to the core js. On KoreanBuilds, some champs are played on different roles, and to know which roles are played, you have an API endpoint, which is this one (I've put Ekko's ID as an example). So as you can see, it's played in top, jungle, and mid. So if you noticed it requires the champion ID, and if I didn't miss anything, we only have access to the champion name. So I added an extra object to the store, called championsInfo, which is created when calling the DDragon API. See d0faaccb90e3e47180c38486d3a0432e0431f070 for how I did it.
Anyway, when building the plugin, I noticed that the Runes Path map was wrong? Or maybe KoreanBuild's map is. But basically, 8300 is the Resolve path, and 8400 is the Inspiration path. So i made a custom map to remap things and now it's okay:
Builds are sorted by Build Confidence, so the most "confident" is first.
If you have any question or anything you want me to change, feel free.