OrangeNote / RuneBook

📖 arcane Rune Pages manager for League of Legends 📜

MIT License

95 stars 65 forks source link

Auto select #38

Open wooles opened 6 years ago

wooles commented 6 years ago

Auto select keeps selected champion i played/picked in a previous lobby. I have to toggle option to change selected champion, should it work like this?

https://a.doko.moe/iriurk.webm (sry for music in the background)

OrangeNote commented 6 years ago

There are still unexplored issues with the auto select feature. I decided to launch it anyway so I can gather more information about it's issues. Testing custom games is not an exhaustive process, unfortunately.

So, answering your question: no, that's not the intended behavior. Does it happen every time or only when you or someone else dodges in champion select?

wooles commented 6 years ago

Gonna test it tomorrow but so far as i noticed it happens every time.

EDIT

Ok, so i tested it today and it seems to be working fine, dunno what caused problem yesterday.

angeldeejay commented 6 years ago

It still failing under certain cases:

When you have a premade, go out off a match and queue again.
When you change match type on lobby
When someones quit on champ select and go back to the queue

I'll gonna review to make a pull request