search

Orasund / elm-ui-widgets

Collection of reusable views for elm-ui.
https://orasund.github.io/elm-ui-widgets/
BSD 3-Clause "New" or "Revised" License
85 stars 11 forks source link

Setting background color of Item causes visual bug #53

Closed Orasund closed 2 years ago

Orasund commented 3 years ago

When setting the background color of a single item (and then using Widget.asItem) the edges will not be correctly rounded.

This can be seen in Widget.headerItem. Not sure how this can be fixed. But most likely it would be a major change.

Not sure if this bug is actually intentionally or not. On the one hand an item should be independent of its content, on the other it is necessary if the background should be set, then it needs to depend on its content.

Remember that one can always create the Item manually:

type alias Item msg =
  List (Attribute msg) -> Element msg
Orasund commented 3 years ago

Fixed the issue for the fullBleedDivider and fullBleedHeader by not relying on the background color. The issue is still present for the insetHeader. Fix is currently on master. Will be release with the next batch update.

cdevienne commented 2 years ago

@Orasund shouldn't this issue be closed?

Orasund commented 2 years ago

thanks