Orasund / elm-ui-widgets

Collection of reusable views for elm-ui.
https://orasund.github.io/elm-ui-widgets/
BSD 3-Clause "New" or "Revised" License
85 stars 11 forks source link

Trouble with custom pallette #93

Open ncc-swann opened 1 year ago

ncc-swann commented 1 year ago

Hi

I am using elm-ui-widgets and generally find it awesome and very useful, so thank you!

I am currently trying to change the default pallette to something custom, but colors do not seem to be represented correctly on screen. I am only changing the primary color of the default pallette for now, leaving the rest alone, but I am experiencing jade represented as light brownish, a shade of blue being represented as green etc.

Do you have any insight into what might be going on?

Best regards Nicolai

Orasund commented 1 year ago

Hi. Could you please create an ellie showcasing the wierd behavior?

ncc-swann @.***> schrieb am Do., 15. Juni 2023, 13:10:

Hi

I am using elm-ui-widgets and generally find it awesome and very useful, so thank you!

I am currently trying to change the default pallette to something custom, but colors do not seem to be represented correctly on screen. I am only changing the primary color of the default pallette for now, leaving the rest alone, but I am experiencing jade represented as light brownish, a shade of blue being represented as green etc.

Do you have any insight into what might be going on?

Best regards Nicolai

— Reply to this email directly, view it on GitHub https://github.com/Orasund/elm-ui-widgets/issues/93, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYRMLHWG2CBEPLC6JCS3LDXLLUSNANCNFSM6AAAAAAZHVZRF4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

ncc-swann commented 1 year ago

Of course. !! Now with updated link to the Ellie !!

Here is a link to the Ellie: https://ellie-app.com/n62jNwkctCHa1 And here is a link to how the CIELCH color used as primary color should look like: https://convertingcolors.com/cielch-color-42_62.639_291.077.html?search=CIELCH(42,%2062.639,%20291.077)#00ABAB

Orasund commented 1 year ago

I'm not sure why this happens. I'm actually relying on noahzgordon/elm-color-extra to convert from LAB to RGB. The conversion from LCH to LAB should be correct (it's just one line, that I double-checked just now).

Also, I never had any problems with that function – I have actually been using it a lot. However, I never tried to directly create a CIELCH color, like you are doing. So my guess is that some factor is wrong somewhere. Maybe the range of my implementation is different to the range used by convertingcolors.com?

I am considering this a niche-problem, and I currently don't have time to fix this. So I will leave it as is.

If you need a fix, please try to find a solution and open a PR.

ncc-swann commented 1 year ago

Thank you for looking into it. People at my company don't like the default purple look, so I will have to come up with a solution eventually.

Orasund commented 1 year ago

Use avh4/elm-color to define colors. You can use any rgb value.