search

Orbiit / elimination

Aka assassination
https://orbiit.github.io/elimination/
MIT License
2 stars 0 forks source link

Option to disable sign ups #30

Closed SheepTester closed 4 years ago

SheepTester commented 4 years ago

Apparently the SEC has a distinction between "sign ups close" and "game starts"

This is rather urgent because sign ups close by midnight today.

There should be a checkbox somewhere on the game settings page to enable/disable sign ups

SheepTester commented 4 years ago

image

SheepTester commented 4 years ago

image Perhaps this is a more appropriate place for it (and better phrasing)

SheepTester commented 4 years ago

image When joining is disabled, we should let them know.

SheepTester commented 4 years ago

API

This does not necessarily require a new endpoint. Perhaps we can build on /game-settings by making it take and return another optional boolean property disableJoining. /game should also return this.

Front end

Api.elm will need a new function (setJoining?) that takes a Bool and a message that takes (). Clicking on the checkbox should automatically send a request to the server. The checkbox should be disabled to indicate that it is loading. If there is a success, there is no indication (the checkbox should automatically be checked). If there's a failure, it'll report it to where other game property saving errors are reported.

SheepTester commented 4 years ago

Alternative temporary solutions

Shutting off the server could work, but the game admins wouldn't be able to see the number of participants.

There's also hacky methods to specifically close joining for the official game past midnight, but that's about as much effort as implementing it properly.

SheepTester commented 4 years ago

SheepTester/scratch-gui#1