search

OrbintSoft / yauaa.netstandard

Yet Another UserAgent Analyzer .NET Standard Porting
Apache License 2.0
24 stars 7 forks source link

Library dependency has internet activity #4

Open DaniilSokolyuk opened 4 years ago

DaniilSokolyuk commented 4 years ago

domainname-parser dependency has internet acitivy https://github.com/OrbintSoft/domainname-parser/blob/ebaa1bf0430b5412a8c51a2bcab0262e7da16df4/DomainParser.Library/TLDRulesCache.cs#L294 library must have a fallback, or settings to turn off it. In private network this cause thread pool exhaustion

image

DaniilSokolyuk commented 4 years ago

All threads wait at that line image

OrbintSoft commented 4 years ago

I don't think the real problem is the internet activity, that library simply downloads an updated version of https://publicsuffix.org/list/public_suffix_list.dat. You can download the file by yourself, and the parser will work fine without internet.

In next version a will add the file as static resource, so it will be available without internet.

Anyway the real issue here is that library causes a thread pool exhaustion.

I am planning to remove that library in any case in a future version because has many issues.

This is the library: https://github.com/danesparza/domainname-parser.

Yauaa uses forked version with .NetStandard compatibility and Strong Signature, but you can refer to that repository.

A

DaniilSokolyuk commented 4 years ago

Ok, thanks. Thanks for your work, this library really good parse user agents :)