search

OrbisWeb3 / orbis-sdk

Official repository for the Orbis SDK.
67 stars 26 forks source link

limit as parameter in getPosts() #7

Closed tempe-techie closed 1 year ago

tempe-techie commented 1 year ago

Currently the getPosts() function in the SDK has a hardcoded post limit at 50.

It would be great if limit was a parameter so that developers could choose a different size limit:

async getPosts(options, page = 0, limit = 50) {

If that only requires changes in this function (and no backend changes), I can do that and push it as PR, to save you some time. Please let me know @baptistegreve 🙂

baptistegreve commented 1 year ago

I actually worked on this last week and it should be available now in version 0.4.32 of the SDK! I will add this to the doc but for now here it is: https://github.com/OrbisWeb3/orbis-sdk/blob/master/index.js#L1324

tempe-techie commented 1 year ago

Awesome, thanks @baptistegreve 🤩 Will update to the newest SDK version 🙂