OrcaCollective / 1-312-hows-my-driving

Easy public vehicle lookup
MIT License
3 stars 8 forks source link

Decimal conversion issue with hourly rate #77

Closed AetherUnbound closed 2 years ago

AetherUnbound commented 2 years ago

We're seeing the following errors in production:

app_1  | https://1312api.tech-bloc-sea.dev/seattle/officer?badge=&first_name=ryan&last_name=
app_1  | ERROR:dataset:[<class 'decimal.ConversionSyntax'>]
app_1  | Traceback (most recent call last):
app_1  |   File "/app/dataset.py", line 82, in name_lookup
app_1  |     else api.render_officers(records, metadata)
app_1  |   File "/app/api.py", line 108, in render_officers
app_1  |     extras = EXTRAS_MAPPING[metadata["id"]](record)
app_1  |   File "/app/extras.py", line 86, in seattle_augment
app_1  |     salary = augment_with_salary(record)
app_1  |   File "/app/extras.py", line 52, in augment_with_salary
app_1  |     return _augment_with_salary_cached(last, first)
app_1  |   File "/app/extras.py", line 40, in _augment_with_salary_cached
app_1  |     projected = Decimal(s["hourly_rate"]) * 40 * 50
app_1  | decimal.InvalidOperation: [<class 'decimal.ConversionSyntax'>]
app_1  | https://1312api.tech-bloc-sea.dev/seattle/officer?badge=&first_name=&last_name=rivera
app_1  | ERROR:dataset:[<class 'decimal.ConversionSyntax'>]
app_1  | Traceback (most recent call last):
app_1  |   File "/app/dataset.py", line 82, in name_lookup
app_1  |     else api.render_officers(records, metadata)
app_1  |   File "/app/api.py", line 108, in render_officers
app_1  |     extras = EXTRAS_MAPPING[metadata["id"]](record)
app_1  |   File "/app/extras.py", line 86, in seattle_augment
app_1  |     salary = augment_with_salary(record)
app_1  |   File "/app/extras.py", line 52, in augment_with_salary
app_1  |     return _augment_with_salary_cached(last, first)
app_1  |   File "/app/extras.py", line 40, in _augment_with_salary_cached
app_1  |     projected = Decimal(s["hourly_rate"]) * 40 * 50
app_1  | decimal.InvalidOperation: [<class 'decimal.ConversionSyntax'>]
app_1  | https://1312api.tech-bloc-sea.dev/seattle/officer/search?first_name=&last_name=rivera
app_1  | ERROR:dataset:[<class 'decimal.ConversionSyntax'>]
app_1  | Traceback (most recent call last):
app_1  |   File "/app/dataset.py", line 82, in name_lookup
app_1  |     else api.render_officers(records, metadata)
app_1  |   File "/app/api.py", line 108, in render_officers
app_1  |     extras = EXTRAS_MAPPING[metadata["id"]](record)
app_1  |   File "/app/extras.py", line 86, in seattle_augment
app_1  |     salary = augment_with_salary(record)
app_1  |   File "/app/extras.py", line 52, in augment_with_salary
app_1  |     return _augment_with_salary_cached(last, first)
app_1  |   File "/app/extras.py", line 40, in _augment_with_salary_cached
app_1  |     projected = Decimal(s["hourly_rate"]) * 40 * 50
app_1  | decimal.InvalidOperation: [<class 'decimal.ConversionSyntax'>]
app_1  | https://1312api.tech-bloc-sea.dev/seattle/officer?badge=5224&first_name=&last_name=
app_1  | https://1312api.tech-bloc-sea.dev/seattle/officer/search?first_name=&last_name=Rivera
app_1  | ERROR:dataset:[<class 'decimal.ConversionSyntax'>]
app_1  | Traceback (most recent call last):
app_1  |   File "/app/dataset.py", line 82, in name_lookup
app_1  |     else api.render_officers(records, metadata)
app_1  |   File "/app/api.py", line 108, in render_officers
app_1  |     extras = EXTRAS_MAPPING[metadata["id"]](record)
app_1  |   File "/app/extras.py", line 86, in seattle_augment
app_1  |     salary = augment_with_salary(record)
app_1  |   File "/app/extras.py", line 52, in augment_with_salary
app_1  |     return _augment_with_salary_cached(last, first)
app_1  |   File "/app/extras.py", line 40, in _augment_with_salary_cached
app_1  |     projected = Decimal(s["hourly_rate"]) * 40 * 50
app_1  | decimal.InvalidOperation: [<class 'decimal.ConversionSyntax'>]
app_1  | https://1312api.tech-bloc-sea.dev/seattle/officer/search?first_name=&last_name=Rivera
app_1  | ERROR:dataset:[<class 'decimal.ConversionSyntax'>]
app_1  | Traceback (most recent call last):
app_1  |   File "/app/dataset.py", line 82, in name_lookup
app_1  |     else api.render_officers(records, metadata)
app_1  |   File "/app/api.py", line 108, in render_officers
app_1  |     extras = EXTRAS_MAPPING[metadata["id"]](record)
app_1  |   File "/app/extras.py", line 86, in seattle_augment
app_1  |     salary = augment_with_salary(record)
app_1  |   File "/app/extras.py", line 52, in augment_with_salary
app_1  |     return _augment_with_salary_cached(last, first)
app_1  |   File "/app/extras.py", line 40, in _augment_with_salary_cached
app_1  |     projected = Decimal(s["hourly_rate"]) * 40 * 50
app_1  | decimal.InvalidOperation: [<class 'decimal.ConversionSyntax'>]