Orcasa-Platform / orcasa-review4c

https://orcasa-review4c.vercel.app/
MIT License
0 stars 0 forks source link

Redesign #71

Closed Bluesmile82 closed 4 months ago

Bluesmile82 commented 4 months ago

Redesign of the module https://vizzuality.atlassian.net/browse/ORC-564?atlOrigin=eyJpIjoiYTkxYmVhNGI2ZTBhNDZhMGJmYjYyMDA3MWUxZmFlMjEiLCJwIjoiaiJ9

Some functionality has changed according to designs.

Rename env.example.js to env.js and fill the Mapbox token

Added also: https://vizzuality.atlassian.net/browse/ORC-652?atlOrigin=eyJpIjoiMWNhMTk4NDg4Y2JkNGZkMWI3YmIzZGIwNjAzMDgxNDAiLCJwIjoiaiJ9

In progress - Responsive

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
orcasa-review4c ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 10:11am
clementprdhomme commented 4 months ago

@Bluesmile82 This feedback is purely based on the final result, I haven't checked the code.

General

Initial screen

Charts screen

Publication screen

Methodology screen

Bluesmile82 commented 4 months ago

The numbers in the footer and the numbers next to the land use types don't add up. Is that because of the mocks we're using?

Yes, this is just an example on the mocks. The numbers come from different endpoints

We're not displaying in any place what land use we're filtering by. Lidia used to have the pill to indicate this. Could you see with her how to solve this? If we bring back the pill, should we also add a land use type filter in the filters sidebar?

We can see the land use the publications are filtered by on the legend of the map. Not sure what do you mean by the pill. On the Main page we can see the selected land use on the dropdown.

It seems that the histogram never updates, even if we don't have any data.

I think this is not supposed to update with the filters, only with the land use. I will fix the no data