search

OrchardCMS / Orchard

Orchard is a free, open source, community-focused Content Management System built on the ASP.NET MVC platform.
https://orchardproject.net
BSD 3-Clause "New" or "Revised" License
2.37k stars 1.12k forks source link

Stop Installed Modules Destroying Your Instance #1804

Closed orchardbot closed 9 years ago

orchardbot commented 13 years ago

jkresner created: https://orchard.codeplex.com/workitem/17976

This is the second community module I've installed that has destroyed a live orchard site. Last time it was FedAuth and only the admin back-end was effected. This time every page on my site is broken!

I installed BlogML (I believe the latest v0.8.1) on an Orchard v1.0 (v.1.0.20.0 from the Admin Dashboard) Half of the value proposition of Orchard is its extensibility and that non-technical people can add contact forms, twitter widgets and the like. Yet if I train my clients to think they can do what they like, they will bring down their own sites which more than 1000 people will hit per day and I will get a top priority call in the middle of the night that it must be fixed immediately. 1) What is being done to correlate the correct version of a module with the current instance of Orchard so that it works and only the correct version can be applied?

2) Where is the SAFE MODE that allows the end user to turn modules off from the user interface without calling up a non-technical person.

3) Where is the direct channel (email link) to the module author to report problems. I think there should be one in each box box the installed modules page.

orchardbot commented 13 years ago

@petehurst commented:

In general you should never allow your clients "site owners" privilege because there will always be modules out there that can break the site to one extent or another. Everything you allow them to have should be tested and supported by you. The same is true of Wordpress or any modular CMS :)

But I do strongly agree that there could be better versioning constraints with modules - both for tying to a specific Orchard version, and to specific dependency versions of 3rd party modules. I'm hitting a lot of problems like this with versioning and generally the solution is to delete all the modules and install each one again; not a friendly experience whether you're technical or not! Safe mode also sounds like a great idea.

Regarding 3) you can go to the Orchard gallery and there's a Contact Module Authors link for every module.

orchardbot commented 12 years ago

@bleroy commented:

The easiest way to restore the site when that happens is to rename the module.txt file. That will disable the module.

orchardbot commented 12 years ago

@pszmyd commented:

I've noticed that in most cases breaking an instance by a module is caused by a module designed for a previous (or future - using dev branch) Orchard version. It would be great to add min/max supported Orchard version info (in Module.txt manifest) and refuse installation of unsupported modules.

orchardbot commented 12 years ago

@pszmyd commented:

Also a good feature would be to specify (like the Dependencies property does) list of module Ids that are known to conflict with the given module. Having one of those installed should prevent the installation (with an appropriate notification).

orchardbot commented 12 years ago

@sebastienros commented:

Fixed in changeset 984064104063

orchardbot commented 12 years ago

@sebastienros commented:

Fixed in changeset 984064104063

orchardbot commented 10 years ago

@sfmskywalker commented:

Fixed in changeset f5810823fba7993f2a5550d03fc65d1bcccdbcd7