Open orchardbot opened 10 years ago
@Piedone commented:
Hmm, this is strange. It does work sometimes. Can't isolate a precise repro yet.
@Piedone commented:
I think I found a repro: it doesn't work if the Save() call is invoked from a background task.
@StanleyGoldman commented:
Fix please!
@Piedone commented:
Related: https://github.com/OrchardCMS/Orchard/issues/4542 https://orchard.codeplex.com/workitem/20713
@Piedone created: https://orchard.codeplex.com/workitem/20413
If you implement the interface in a custom module your implementation won't get called when the event is fired. IShellSettingsManagerEventHandler is somewhat special but nevertheless it's an IEventHandler so one expects it to work as any other event handler.
Tested on current latest 1.x and 1.7.x, neither works. I don't know whether this worked at all once.
We could solve this for example by calling OrchardHost.EndRequest() or something similar when all background tasks are executed (and thus process ProcessingEngine tasks as well as restart changed shells).