Change Funcs and Actions to explicit delegate in public interfaces

[Piedone]

Having Func<T1, T2, ...> or Action<T1, T2,...˙> delegates in public interfaces is most of the times confusing, since you don't know the meaning of the arguments. If there is a single output or a single input/output argument, that is most of the time fine, but it's gets really hard to understand once we have three-four type parameters for Func.

E.g. you have to dig through the code to eventually find out that the parameters of the Func<string, string, string, PlacementInfo> stored in BuildShapeContext.FindPlacement expects shapeType, differentiator, location.

Instead, we could define explicit delegates, e.g. for the above:

public delegate PlacementInfo PlacementFinder(string shapeType, string differentiator, string location);

I'm sure there are similar cases elsewhere too.

A quite similar issue is #4759.

[sfmskywalker]

+1

[MpDzik]

+1

[Piedone]

And this makes you wonder why GitHub doesn't have a voting feature for issues. Probably the only aspect in what Codeplex is better :-).

[sfmskywalker]

Yeah exactly. Maybe submit an issue for that? ;)

[Piedone]

There is one :-): https://github.com/isaacs/github/issues/9 Well, kind of...

[sebastienros]

Breaking change :/

[sebastienros]

Or maybe not breaking ...

[Piedone]

Not breaking :-).

[MpDzik]

Theoretically, it can be breaking if someone explicitly created a Func<T1, T2, ...> and passed it as an argument. However, I think everyone uses lambda expressions these days, so this shouldn't be a problem.