search

OrchardCMS / Orchard

Orchard is a free, open source, community-focused Content Management System built on the ASP.NET MVC platform.
https://orchardproject.net
BSD 3-Clause "New" or "Revised" License
2.37k stars 1.12k forks source link

Feature: Two-Factor Authentication #5919

Open emeraldarcher opened 8 years ago

emeraldarcher commented 8 years ago

Would two-factor authentication be of interest for Orchard's core set of modules or would a feature such as this be better if it remained separate? This also begs to question the possibility of an SMS module similar to Email as well as a profile area for users.

Piedone commented 8 years ago

Since such a module can't function without an external piece of infrastructure (since you have to connect to something to send an SMS) it can't fully baked in. But a basic and generic, extensible one (that would let you plug in e.g. some SMS-sending service or an authentication app) could be built in.

emeraldarcher commented 8 years ago

Okay, I created modules for some clients that add SMS and Two-Factor Authentication using twilio and Google Authenticator, but built them using interfaces and extending IDependency so another developer could come in and change the actual service. Sounds like these may be better left separate though.

sebastienros commented 8 years ago

This and https://github.com/OrchardCMS/Orchard/issues/5553 should be done at the same time.

emeraldarcher commented 8 years ago

@sebastienros that would make sense to do both together. Are you thinking more along the lines of something generic like @Piedone mentioned? I think TFA could be built in to utilize email as the default and then a method could be created for allowing services to plug in such as sms or Google's authenticator app.