search

OrchardCMS / Orchard

Orchard is a free, open source, community-focused Content Management System built on the ASP.NET MVC platform.
https://orchardproject.net
BSD 3-Clause "New" or "Revised" License
2.37k stars 1.12k forks source link

Orchard.Resources: wrong dependency for jQueryUI_Position resource. Is now jQuery, should be jQueryUI #6317

Open jvdonk opened 8 years ago

jvdonk commented 8 years ago

Stumpled upon a JavaScript error when using the jQueryUI_Position resource:

image

The .ui propery isn't defined as jQueryUI isn't loaded because in Orchard.Resources in jQuery.cs it is stated that the jQueryUI_Position resource is dependent on jQuery but that should be jQueryUI as it is a jQueryUI plugin.

manifest.DefineScript("jQueryUI_Position").SetUrl("ui/position.min.js", "ui/position.js").SetVersion("1.11.4").SetDependencies("jQuery");

Should be(look at the end of the line):

manifest.DefineScript("jQueryUI_Position").SetUrl("ui/position.min.js", "ui/position.js").SetVersion("1.11.4").SetDependencies("jQueryUI");

When changed, error is gone and positioning works fine.

infofromca commented 8 years ago

fixed, should close it