OrchardCMS / Orchard

Orchard is a free, open source, community-focused Content Management System built on the ASP.NET MVC platform.
https://orchardproject.net
BSD 3-Clause "New" or "Revised" License
2.37k stars 1.12k forks source link

8642: Adding "Build Crowdin Translation Packages" workflow #8660

Closed BenedekFarkas closed 1 year ago

BenedekFarkas commented 1 year ago

Fixes #8642

Successful job execution for commit 498e0c6: https://github.com/OrchardCMS/Orchard/actions/runs/4489388067/jobs/7895144432

Successful job execution for commit 6fc93f4: https://github.com/OrchardCMS/Orchard/actions/runs/4491534994/jobs/7900123857

andrii-bodnar commented 1 year ago

Hey everyone,

just accidentally noticed this PR. I highly recommend not using the API v1. It's deprecated and it's going to be removed. Please use the API v2 - https://developer.crowdin.com/api/v2/

in addition, I'd recommend the following GH Actions that might simplify your workflow and make integration with Crowdin much easier:

BenedekFarkas commented 1 year ago

@andrii-bodnar thanks for the recommendation, I'll check it out!

andrii-bodnar commented 1 year ago

@BenedekFarkas please note that the build in API v2 is an asynchronous process so it will require more API calls to do it.

Here is an example of such a case - https://github.com/andrii-bodnar/crowdin-request-action/blob/main/EXAMPLES.md#build-project-translations (if to use the crowdin-request-action. In case of Crowdin GH Action it already under the hood)

BenedekFarkas commented 1 year ago

Thanks Andrii, the async call will be fine for now, because the projects have very little activity, so this is about keeping them up-to-date, just in case.

andrii-bodnar commented 1 year ago

@BenedekFarkas do you just need to build the projects and the translations download happens somewhere else?

BenedekFarkas commented 1 year ago

@andrii-bodnar downloading the packages is completely independent, because the translations are publicly available, so anyone can just grab any language package they want.