search

OrchardCMS / Orchard

Orchard is a free, open source, community-focused Content Management System built on the ASP.NET MVC platform.
https://orchardproject.net
BSD 3-Clause "New" or "Revised" License
2.38k stars 1.12k forks source link

8773: Merge 1.10.x into dev #8774

Closed BenedekFarkas closed 7 months ago

BenedekFarkas commented 8 months ago

Fixes #8773

MatteoPiovanelli-Laser commented 8 months ago

Looks like the compilation step for this is failing with the same error we saw in #8746 (but form a different project). Hopefully we have some luck figuring it out here. We've been trying to fix it, but compilation on our end doesn't fail, whether we do it in VS, or using msbuild (either with the options used in the action on github here, or the different combination we use when we release).

BenedekFarkas commented 8 months ago

I'll look into that, but I'm working on the merge itself right now (and some other issues I found along the way). There were new features added to the Email feature on dev that need to be integrated with Mailkit overhaul, so I'm currently validating that it's still working.

Would retargeting the Mailkit version upgrade to dev be OK for you?

MatteoPiovanelli-Laser commented 8 months ago

"Would retargeting the Mailkit version upgrade to dev be OK for you?" I think so. Let me tag @AndreaPiovanelli on that as a reminder for him to check, since he was looking into it recently.

BenedekFarkas commented 7 months ago

@HermesSbicego-Laser @LorenzoFrediani-Laser this is a PR for integrating changes from 1.10.x into dev and it affects your previously merged PRs (#7338 and #7669) due to the MailKit upgrade. I did test it all locally, but if you can, please check it out whether it's still working as expected.