Incorrect NOLOCK position in queries where there is no table alias

OrchardCMS / Orchard

Orchard is a free, open source, community-focused Content Management System built on the ASP.NET MVC platform.

https://orchardproject.net

BSD 3-Clause "New" or "Revised" License

2.37k stars 1.12k forks source link

Incorrect NOLOCK position in queries where there is no table alias #8783

Closed AndreaPiovanelli closed 2 months ago

AndreaPiovanelli commented 2 months ago

In reference to issue #8782 , "WITH(NOLOCK)" clause is now placed after the table name if there is no alias provided for the table but before the "WHERE" clause.

BenedekFarkas commented 2 months ago

I can't speak to the PR functionality-wise and as far as I can see there aren't any tests that would cover it (any chance you could add some?). Code-wise good to go from me!