search

OrchardCMS / Orchard

Orchard is a free, open source, community-focused Content Management System built on the ASP.NET MVC platform.
https://orchardproject.net
BSD 3-Clause "New" or "Revised" License
2.37k stars 1.12k forks source link

Orchard.Core has a 'Orchard.Users' reference in User.cshtml #993

Open orchardbot opened 13 years ago

orchardbot commented 13 years ago

@jetski5822 created: https://orchard.codeplex.com/workitem/17161

Nothing in Orchard.Core should know about any modules. If for example I wanted to take out Orchard.Users, Orchard.Core would need to be modified... if this is meant to happen then Orchard.Users should be pushed down in to Orchard.Core.

Nick

orchardbot commented 13 years ago

rpaquay commented:

Re-triage. This is true, however if someone creates a new module (e.g. ActiveDirectoryUsers), a new "user.cshtml" can be put in that module and will override the ones in Core/Shapes.

orchardbot commented 13 years ago

@jetski5822 commented:

Well.. Surely the Core framework should have zero ties to the modules right (seperation of concerns))? If this stays this way... then this rule is broken... right?

orchardbot commented 13 years ago

rpaquay commented:

Yes, you are absolutely right. However, we are a couple of days from delivering 1.0, and we have to make tough choices...

orchardbot commented 13 years ago

@jetski5822 commented:

Thats cool... but no reason it cant be fixed after 1.0 :)