search

OrchardCMS / OrchardCore.Commerce

The commerce module for Orchard Core.
MIT License
219 stars 90 forks source link

Complete the list with other countries that have regions (OCC-70) #112

Open sarahelsaig opened 2 years ago

sarahelsaig commented 2 years ago

https://github.com/OrchardCMS/OrchardCore.Commerce/blob/e9dba990fbf2359dffa5af31126a800e59ad4118/AddressDataType/Regions.cs#L30-L35

(This issue was created as part of the effort to externalize TODOs from the code base.)

Jira issue

sarahelsaig commented 1 year ago

Geopolitics can be fluent and unnecessarily political. So I'd prefer to make this modular and let the e-store devs provide the regions they actually need rather than us trying to compile a fixed list. Also if you know any third party APIs that provide up-to-date region information, please chime in. Such API could be used in an optional provider to fetch region information without us having to maintain data.

Also OrchardCore.Commerce.AddressDataType.Regions.All should not be used directly either. It should be returned by the optional default provider. It's suitable for most western use-cases, but for example CultureInfo.GetCultures(CultureTypes.SpecificCultures) does not include Taiwan/Republic of China yet some may want to ship product there.