Open hishamco opened 1 year ago
@Piedone can I have access to this repo in case I need to push a PR, or shall I fork, then commits from the forked repo?
@DAud-IcI is the project leader here, so Dávid please advise,
I don't mind. @hishamco, I've added you to the developers group, please check if you have the access.
Hope to contribute to the repo in the upcoming future, thanks David
IMHO, if you don't have the time to invest in a dedicated Commerce theme, TheTheme would be a better default choice than TheBlogTheme.
What's the advantage of using TheTheme vs TheBlogTheme?
The default recipe that you provide is meant to show the features than the module offers. You should focus on demonstrating to first time users what they would expect from an ECommerce module (Product listing on homepage, search, product details, add to cart).
Using TheBlogTheme can be kind of a misguiding distraction for the user. One way to showcase only the features would be to use the default theme.
But then, I guess we all agree that the most fitted UI would be a simple commerce theme as Hisham suggested:
For anyone taking this: move the Modules/OrchardCore.Commerce/Assets/Styles/general/_error.scss into the theme instead.
@sarahelsaig can I add this theme to https://github.com/OrchardCoreContrib/OrchardCoreContrib.Themes then we could override the views (something similar to the blog theme) or shall we add it into the repo
You can add a base theme into OrchardCoreContrib.Themes if that helps your workflow, but the theme and the OCC-specific views should be in this repo. Or did you mean something else?
but the theme and the OCC-specific views should be in this repo
Sure, or we could override them, let me have a deep look to the current customization in TheBlog
theme then I can follow it
Note for when this is done: check if allowInlineStyle
is still needed in Program
.
I will busy nowadays with revising and finalizing OC PRs then I can have time for other related OC stuff
it would be nice to use eCommerce theme instead of building on top of the Blog theme. We could use something like https://startbootstrap.com/templates/ecommerce I can submit a PR if the team agrees with the idea
Jira issue