Re-evaluate use CreateModelMaybeAsync (OCC-280)

OrchardCMS / OrchardCore.Commerce

The commerce module for Orchard Core.

MIT License

210 stars 87 forks source link

Re-evaluate use CreateModelMaybeAsync (OCC-280) #479

Open MikeAlhayek opened 1 month ago

MikeAlhayek commented 1 month ago

Suggestion based on quick review of code. The method CreateModelMaybeAsync should no longer be used

More about the reasoning can be found here

Jira issue

sarahelsaig commented 1 month ago

When the driver is converted from SectionDisplayDriver to SiteDisplayDriver, the groupId parameter may be removed (set to null) in the method call. No other action is necessary.