search

OrchardCMS / OrchardCore.Commerce

The commerce module for Orchard Core.
MIT License
218 stars 90 forks source link

.NET 6.0 application bootstrapping (OCC-71) #97

Closed Skrypt closed 1 year ago

Skrypt commented 2 years ago

As suggested by @jhgbrt

It would be a good thing to use the new way of bootstrapping the application in .NET 6.0 Maybe there is a way to use it even if we are multi-targeting frameworks on the CI.

Jira issue

barthamark commented 2 years ago

@DAud-IcI please confirm that this is addressed by https://github.com/OrchardCMS/OrchardCore.Commerce/pull/119

sarahelsaig commented 2 years ago

Nope, SampleWebApp still uses the generic host builder style. #119 didn't do functional changes unless it seemed necessary.

Maybe there is a way to use it even if we are multi-targeting frameworks on the CI.

What other frameworks do you have in mind, @Skrypt ? I think we only need to target .Net 6, becuase that's what OC 1.3 requires.

Skrypt commented 2 years ago

Even though we currently only target net6.0; when net7.0 will be eventually out, we will surely multi-target to keep an LTS version in the build pipeline. So, you need to keep in mind that we are going to eventually multi-target.

sarahelsaig commented 2 years ago

Yes, that makes sense. I just got confused, becuase the new style application boostrapping should be forward-compatible so .Net 7 wouldn't have any effect on the issue topic.

We could take a look at multi-targeting with the 7.0.0-preview.3 SDK (in a container, becuase installing preview SDKs on bare metal is never a good time). But that should be a separate issue, I think.

Skrypt commented 2 years ago

I believe this is why we dropped net3.1 and net5.0.

sarahelsaig commented 1 year ago

Looks like this was done during https://github.com/OrchardCMS/OrchardCore.Commerce/issues/212#issuecomment-1285748447 (see the diff here)