Open DemeSzabolcs opened 2 years ago
As @Skrypt said earlier we are not the creators of the themes and we should use theme as it is
While with https://github.com/OrchardCMS/OrchardCore/issues/11241 I kind of agree that it's better to fix in the theme (since the fix is not just a technical one but affects the design), here I don't see why we'd need to keep these errors and wait for an update in the original project: The Liquid code is a derivative work, not part of the original template but part of Orchard, and the fixes are solely technical. We can fix them in Orchard and at the same time let the original author now about them to fix them in the original code too.
Let me follow up under the PR.
There's a new issue in the Blog theme, duplicated fas
class:
And there's a new accessibility issue with The Default Theme too. This is an HTML file, just rename to .html, but GitHub doesn't allow uploading them. AccessibilityReport.txt
Remove the first "fas" since this seems to be added from database with the IconPicker. But maybe it was added for backward compatibility when we switched to a new version of FontAwesome for those who we're using "fa" instead of "fas". So, if that's the case then the issue is that the IconPicker saves "fas" in the database.
Just fix what is specifically added by us, or file issues in the official repos with PR if possible. Then we'll update the templates.
Describe the bug
There are accessibility problems in:
Additional Info: Links must have discernible text: > > > > > > > > >
Asserting the accessibility analysis result failed. Check the accessibility report failure dump for details. -------- Shouldly.ShouldAssertException : axeResult.Violations should be empty but had 1 item and was [Selenium.Axe.AxeResultItem (14851760)]
Additional Info: Links must have discernible text: > > >
" Check the HTML validation report in the failure dump for details. -------- Shouldly.ShouldAssertException : validationResult.Output should be empty but was "12bbd89b-7645-413b-a1d3-d69909ac40b9.html 25:55 error The autoplay attribute is not allowed on
Ôťľ 2 problems (2 errors, 0 warnings)
More information: https://html-validate.org/rules/no-autoplay.html https://html-validate.org/rules/attribute-allowed-values.html "