Closed sebastienros closed 2 years ago
it's main
now not master
:)
BTW since then, GitHub can generate pretty nice release notes with a click of a button between two tags: https://github.com/Lombiq/UI-Testing-Toolbox/releases/tag/v1.7.0 We could just use this instead of custom release notes in the docs. (But still with highlights and notes about breaking changes added, so everything that can't be auto-generated.)
Shouldn't OrchardCore.ProjectTemplates
reference 1.3.0? It now references 1.3.0-preview-16386.
GitHub can generate pretty nice release notes with a click of a button between two tags
This is what we use in the release notes, and what we copy in the md file
Shouldn't OrchardCore.ProjectTemplates
Oopsy!
I don't see the issue in NuGet.org, where should we look at ?
It's there. If you download the OrchardCore.ProjectTemplates
package in e.g. content\OrchardCore.Templates.Cms.Module.template.config\template.json you'll see:
"OrchardVersion": {
"type": "parameter",
"datatype": "string",
"description": "Specifies which version of Orchard Core packages to use.",
"replaces": "$(TemplateOrchardPackageVersion)",
"defaultValue": "1.3.0-preview-16386"
}
Ok, will fix the issue template too then, not precise enough. Will try to update the package with 1.3.0.1, and update the doc to use this version. I want to prevent a 1.3.1 just for that, there might be other things to fix we find soon.
https://www.nuget.org/packages/OrchardCore.ProjectTemplates/1.2.2 had:
"defaultValue": "1.2.2-preview-16385"
I have to admit that I noticed that too but didn't bring it up :(.
Ok, let's fix it and just update the doc to force the value to 1.3.0 in the arguments. I am also updating the checklist so it doesn't get unnoticed next time.
There is nothing to update in the templates, it should have used the build number automatically. I think there might be an issue with the build order.
I think it's related to this:
dotnet pack
is forced with 1.3.0
(the release tag) but the build number might still be the same as for the preview builds, an incremental value. In this workflow we should set it to a fix number too I guess.
Found the reason and the solution. We are generating the BuildNumber property as I mentioned in the previous post. But it's fine. What is necessary is to remove the VersionSuffix
value (currently preview
) and this won't be appended to the metadata:
AssemblyFileVersion:1.3.0.0
AssemblyInformationalVersion:1.3.0-preview-16386+62eed89890b6b9b6d71a02e1465269b9bb512207
This PR makes it clear for next release https://github.com/OrchardCMS/OrchardCore/pull/11351
Users can add --orchard-version 1.3.0
on project templates for now. We'll remove the note with next release.
1.3 doesn't support .netcoreapp3.1 or .net5 so It would be nice if we have that added in issue title / in readme
Create a new milestone 1.4
Prepare the project
Do some housekeeping on GitHub in the main repo.
Prepare the code
Update the source so everything looks like on the new version.
release/<version name>
branch out ofmain
.OrchardCore.ProjectTemplates
.OrchardCore.Commons.props
file: UpdateVersionPrefix
for release versions (like "1.0.0") andVersionSuffix
for pre-release versions (like "rc2", for the full version to be e.g. "1.0.0-rc2").ManifestConstants
.Test the release
Make sure everything works all right.
release/
are automatically published too). Test at least the following guides:Prepare and publish Orchard Core Translations
Update everything in the Translations project. Only do this once all the code changes are done since localized strings can change until then.
OrchardCore.Translations.All
package reference in the main repo's src/OrchardCore.Build/Dependencies.props file to refer to the new NuGet package.Prepare the documentation
Update the docs so they contain information about the new release so once the release is out you'll just need to point to new information.
changelog OrchardCMS OrchardCore <previous version> <current version>
command, e.g.changelog OrchardCMS OrchardCore 1.0.0-rc1 1.0.0-rc2
. Alternatively, you can use Antoine's app too.Publish the release
Do the harder parts of making the release public. This should come after everything above is done.
release/<version name>
tomaster
.master
need two approvals so you'll need to create a pull request.master
with the full version name, including the prefix and suffix (e.g. "1.0.0-rc2").Publicize the release
Let the whole world know about our shiny new release. Savor this part! These steps will make the release public so only do them once everything else is ready.
For details on this version see the [release notes in the documentation](link here).
). Add a link to this release under Status in the root README.