search

OrchardCMS / OrchardCore

Orchard Core is an open-source modular and multi-tenant application framework built with ASP.NET Core, and a content management system (CMS) built on top of that framework.
https://orchardcore.net
BSD 3-Clause "New" or "Revised" License
7.23k stars 2.34k forks source link

Async Support for Loading Translations #11356

Open hishamco opened 2 years ago

hishamco commented 2 years ago

While I'm working on DataLocalization support, I realize that ITranslationProvider.LoadTranslations should support async for loading translations from database or any store without blocking.

I know this will be a breaking change but it's good improvement for 2.0.0

sebastienros commented 2 years ago

It's a minor breaking change, I don't think many have implemented this. Maybe check if we have a breaking change label, and create it if not to add it to the PR. Also change the release instructions to check for this label and mention them in the release notes.

sebastienros commented 2 years ago

Not sure about the NuGet packages though, it's not just Orchard CMS.