OrchardCMS / OrchardCore

Orchard Core is an open-source modular and multi-tenant application framework built with ASP.NET Core, and a content management system (CMS) built on top of that framework.
https://orchardcore.net
BSD 3-Clause "New" or "Revised" License
7.37k stars 2.38k forks source link

Workflows need audit trail support #11608

Open deanmarcussen opened 2 years ago

deanmarcussen commented 2 years ago

Impossible to track down who broke them without audit trail...

hyzx86 commented 4 months ago

Hi @deanmarcussen , I'm working on https://github.com/OrchardCMS/OrchardCore/pull/16043

While I have added the workflow version field, it is only there to preserve the existing process instance when importing from a recipe. If I add the Audit field, I can currently only query the last version . Since we are currently using a workflow interface that is not a single page application, every time we create/update the node settings it triggers a workflow update, which can cause a lot of versions to be generated.

Do you have any other suggestions for information regarding auditing? Thanks!

deanmarcussen commented 4 months ago

Hi @hyzx86 great to see someone adding some audit trail information to workflows, it is sorely needed.

Yes, worfklows are not a spa, so there is a lot of saves that occur as your are adding and/or removing or changing activities.

From my experience using them, this is actually the kind of information you need to capture during an audit, so seeing many different versions turn up, is good, and helpful.

The most common reason we need it, is because someone deleted or changed an activity (often for debuging or fixing / testing something) and then didn't turn it back on. So having that audit of the whole history of it, is a good thing.

I don't fully understand the version field, however have not had time to read the pr and understand.