Bootswatch files are out-of-sync

OrchardCMS / OrchardCore

Orchard Core is an open-source modular and multi-tenant application framework built with ASP.NET Core, and a content management system (CMS) built on top of that framework.

https://orchardcore.net

BSD 3-Clause "New" or "Revised" License

7.45k stars 2.41k forks source link

Bootswatch files are out-of-sync #12428

Open sebastienros opened 2 years ago

sebastienros commented 2 years ago

c.f. https://github.com/OrchardCMS/OrchardCore/pull/12372

The original files are from https://github.com/thomaspark/bootswatch/tree/v5/dist/darkly

We should try to update these to keep in-sync and maybe put customizations in a different file. Also put a comment in the copied file to explain where to find the source and how to update it.

Skrypt commented 2 years ago

If someone takes on that task I might say that the bootswatch file has been modified to import our own customizations so that's why it is different. We may add instead an import to a bootswatch-override.scss file but we would need to test and make sure everything will still work because CSS is always interpreted from top to bottom and sometimes playing with the order of imports can break things.