search

OrchardCMS / OrchardCore

Orchard Core is an open-source modular and multi-tenant application framework built with ASP.NET Core, and a content management system (CMS) built on top of that framework.
https://orchardcore.net
BSD 3-Clause "New" or "Revised" License
7.38k stars 2.38k forks source link

Upgrade to external module update creates version in-consistency in orchard core #12827

Open ns8482e opened 1 year ago

ns8482e commented 1 year ago

Describe the bug

An Web application targets specific meta version of orchard and uses external module that targets same orchard version, when new release is available for external module that depends on new version of orchard - if developer decides to upgrade the module, nuget successfully updates the module but only updates orchard's dependent modules to new version - but remaining orchard modules remains on older version - results in application being mix version state

1, and uses an external module that originally targets 1.4.0 - when upgraded to 1.5.0

To Reproduce

Steps to reproduce the behavior:

  1. Create web application with OrchardCore.Application.Cms.Core.Targets - 1.4.0
  2. Add reference to external module that target 1.4.0
  3. Upgrade the module to 1.5 that depends on Orchard Core version 1.5
  4. Notice that Nuget only updates DLLs that is dependency of external module.

Expected behavior

Nuget should update Orchard to 1.5 or raise an error. All orchard provided nuget packages should have dependency for same version i.e. 1.5.0 >= 1.5.x < 1.6.0, that forces nuget to update all dlls

Piedone commented 5 months ago

We could maybe extend MSBuild to display a warning in this case or something.