search

OrchardCMS / OrchardCore

Orchard Core is an open-source modular and multi-tenant application framework built with ASP.NET Core, and a content management system (CMS) built on top of that framework.
https://orchardcore.net
BSD 3-Clause "New" or "Revised" License
7.35k stars 2.37k forks source link

The "Noembed" option in Trumbowyg editor does not work unless we prevent sanitization #13885

Open MikeAlhayek opened 1 year ago

MikeAlhayek commented 1 year ago

Describe the bug

When using HTML editor with Trumbowyg editor, by default we allow Noembded option which allow the user to insert media link YouTube videos.

However, by default HtmlPart is configured to Sanitize the HTML. If you try to insert a YouTube video, it wont insert anything. It works only if we checked "Sanitize" option.

To Reproduce

Steps to reproduce the behavior:

  1. Add HTML part to any content type.
  2. Change the editor to use Trumbowyg editor.
  3. Try using Noembded option and insert a YouTube video.
sebastienros commented 1 year ago

Should we remove the option to use noembed by default? Then users can decide to both configure the sanitization and add it to the trumbowyg options.