Closed Piedone closed 6 months ago
I'm also updating the release publishing guide at the same time. @MikeAlhayek why do we actually need a release branch? It seems to me that we only ever commit to it once. We don't need a branch for that, rather only a tag, what we add anyway.
Ah, so we can target PRs on it.
Can you please update Try Orchard Core @agriffard?
@sebastienros please tweet this from OrchardCMS (or adjust as you see fit):
The Orchard Core community released v1.8.3! This is a security release, updating vulnerable versions of the Azure.Identity and SixLabors.ImageSharp.Web packages.
See the release notes here: https://docs.orchardcore.net/en/latest/docs/releases/1.8.3/. We recommend that you update your applications immediately.
Can you please update Try Orchard Core @agriffard?
I will, but currently I have this error running it locally :
Unable to find a stable package OrchardCore.FileStorage.AmazonS3 with version (>= 1.8.3)
- Found 137 version(s) in OrchardCoreDev [ Nearest version: 1.9.0-preview-18033 ]
- Found 9 version(s) in nuget.org [ Nearest version: 1.8.2 ]
- Found 0 version(s) in C:\Program Files\dotnet\library-packs TryOrchardCore.Web
Thank you!
That's out though: https://www.nuget.org/packages/OrchardCore.FileStorage.AmazonS3/1.8.3. So, my guess is that this is some caching issue. I've seen this happening with fresh NuGets. Most possibly you just need to wait like 30 minutes, and restart VS to be sure.
https://try.orchardcore.net/ updated to 1.8.3
That was quick, thank you!
Thanks for the update!
Unfortunately it seems like that some OC packages are still using an old version of Azure.Identity (1.10.3)
which has a open security vulnerability:
This issue is fixed with version 1.11.0
: https://osv.dev/vulnerability/GHSA-wvxc-855f-jvrv
https://orchardcore.net/ updated to 1.8.3. Portfolio updated to the latest ones appearing on ShowOrchard. Links added in top bar.
@sabifa where Orchard Core uses Azure.Identity
directly, the latest version is referenced. What your tool shows is that Microsoft.Data.SqlClient
v5.2.0 depends on Azure.Identity
>= 1.10.3. OC uses that package implicitly via YesSql, which we use for data access. Thus, if you only use packages from Orchard Core that depend on YesSql but not directly on Azure.Identity
(what only two of them do) then, depending on the rest of your application, v1.10.3 may be resolved.
I don't think we can feasibly do anything with this.
@agriffard great, looks very nice!
@sebastienros please? https://github.com/OrchardCMS/OrchardCore/issues/15824#issuecomment-2078116584
@Piedone Thanks for the clarification!
I timed out on Twitter.
This is needed to patch https://osv.dev/vulnerability/GHSA-65x7-c272-7g7r and https://nvd.nist.gov/vuln/detail/CVE-2024-29992. Already covered in
main
.Prepare the project
Do some housekeeping on GitHub in the main repo.
Prepare the code
Update the source so everything looks like on the new version.
release/<version name>
branch out ofmain
, e.g.release/1.8
.OrchardCore.Commons.props
file with<VersionSuffix></VersionSuffix>
such that preview build numbers are not injected in packages. Verify theVersionPrefix
tag matches the released version.src/OrchardCore/OrchardCore.Abstractions/Modules/Manifest/ManifestConstants.cs
.Test the release
Make sure everything works all right.
OrchardCore.Samples
works. - Not needed.release/
are automatically published too). Test at least the following guides: - Not needed.Prepare and publish Orchard Core Translations - Not needed, localized strings didn't change.
Update everything in the Translations project. Only do this once all the code changes are done since localized strings can change until then.
OrchardCore.Translations.All
package reference in the main repo's src/OrchardCore.Build/Dependencies.props file to refer to the new NuGet package.Prepare the documentation
Update the docs so they contain information about the new release so once the release is out you'll just need to point to new information.
vx.y.z
that is created when the release is published. Auto-generate release notes. - Not needed, only a published release.Publish the release
Do the harder parts of making the release public. This should come after everything above is done.
release/<version name>
tomain
.main
need two approvals so you'll need to create a pull request.Publicize the release
Let the whole world know about our shiny new release. Savor this part! These steps will make the release public so only do them once everything else is ready.
For details on this version see the [release notes in the documentation](link here).
).After the release is done - Not needed.
/releases/1.8.0.md
).OrchardCore.Commons.props
file with the next release number, and<VersionSuffix>preview</VersionSuffix>
such that preview builds use the new one.