OrchardCMS / OrchardCore

Orchard Core is an open-source modular and multi-tenant application framework built with ASP.NET Core, and a content management system (CMS) built on top of that framework.
https://orchardcore.net
BSD 3-Clause "New" or "Revised" License
7.43k stars 2.4k forks source link

Release v1.8.3 #15824

Closed Piedone closed 6 months ago

Piedone commented 6 months ago

This is needed to patch https://osv.dev/vulnerability/GHSA-65x7-c272-7g7r and https://nvd.nist.gov/vuln/detail/CVE-2024-29992. Already covered in main.

Prepare the project

Do some housekeeping on GitHub in the main repo.

Prepare the code

Update the source so everything looks like on the new version.

Test the release

Make sure everything works all right.

Prepare and publish Orchard Core Translations - Not needed, localized strings didn't change.

Update everything in the Translations project. Only do this once all the code changes are done since localized strings can change until then.

Prepare the documentation

Update the docs so they contain information about the new release so once the release is out you'll just need to point to new information.

Publish the release

Do the harder parts of making the release public. This should come after everything above is done.

Publicize the release

Let the whole world know about our shiny new release. Savor this part! These steps will make the release public so only do them once everything else is ready.

After the release is done - Not needed.

Piedone commented 6 months ago

I'm also updating the release publishing guide at the same time. @MikeAlhayek why do we actually need a release branch? It seems to me that we only ever commit to it once. We don't need a branch for that, rather only a tag, what we add anyway.

Piedone commented 6 months ago

Ah, so we can target PRs on it.

Piedone commented 6 months ago

Can you please update Try Orchard Core @agriffard?

Piedone commented 6 months ago

@sebastienros please tweet this from OrchardCMS (or adjust as you see fit):

The Orchard Core community released v1.8.3! This is a security release, updating vulnerable versions of the Azure.Identity and SixLabors.ImageSharp.Web packages.

See the release notes here: https://docs.orchardcore.net/en/latest/docs/releases/1.8.3/. We recommend that you update your applications immediately.
agriffard commented 6 months ago

Can you please update Try Orchard Core @agriffard?

I will, but currently I have this error running it locally :

Unable to find a stable package OrchardCore.FileStorage.AmazonS3 with version (>= 1.8.3)
  - Found 137 version(s) in OrchardCoreDev [ Nearest version: 1.9.0-preview-18033 ]
  - Found 9 version(s) in nuget.org [ Nearest version: 1.8.2 ]
  - Found 0 version(s) in C:\Program Files\dotnet\library-packs TryOrchardCore.Web
Piedone commented 6 months ago

Thank you!

That's out though: https://www.nuget.org/packages/OrchardCore.FileStorage.AmazonS3/1.8.3. So, my guess is that this is some caching issue. I've seen this happening with fresh NuGets. Most possibly you just need to wait like 30 minutes, and restart VS to be sure.

agriffard commented 6 months ago

https://try.orchardcore.net/ updated to 1.8.3

Piedone commented 6 months ago

That was quick, thank you!

sabifa commented 6 months ago

Thanks for the update!

Unfortunately it seems like that some OC packages are still using an old version of Azure.Identity (1.10.3) which has a open security vulnerability: image

This issue is fixed with version 1.11.0: https://osv.dev/vulnerability/GHSA-wvxc-855f-jvrv

agriffard commented 6 months ago

https://orchardcore.net/ updated to 1.8.3. Portfolio updated to the latest ones appearing on ShowOrchard. Links added in top bar.

Piedone commented 6 months ago

@sabifa where Orchard Core uses Azure.Identity directly, the latest version is referenced. What your tool shows is that Microsoft.Data.SqlClient v5.2.0 depends on Azure.Identity>= 1.10.3. OC uses that package implicitly via YesSql, which we use for data access. Thus, if you only use packages from Orchard Core that depend on YesSql but not directly on Azure.Identity (what only two of them do) then, depending on the rest of your application, v1.10.3 may be resolved.

I don't think we can feasibly do anything with this.

@agriffard great, looks very nice!

Piedone commented 6 months ago

@sebastienros please? https://github.com/OrchardCMS/OrchardCore/issues/15824#issuecomment-2078116584

sabifa commented 6 months ago

@Piedone Thanks for the clarification!

Piedone commented 6 months ago

I timed out on Twitter.