search

OrchardCMS / OrchardCore

Orchard Core is an open-source modular and multi-tenant application framework built with ASP.NET Core, and a content management system (CMS) built on top of that framework.
https://orchardcore.net
BSD 3-Clause "New" or "Revised" License
7.38k stars 2.38k forks source link

Deprecated packages #15977

Open agriffard opened 4 months ago

agriffard commented 4 months ago

Warnings on some packages in Installed tab of Nuget packages in VS:

https://www.nuget.org/packages/NEST/7.17.5 Suggested Alternatives Elastic.Clients.Elasticsearch

https://www.nuget.org/packages/Irony.Core/1.0.7 Suggested Alternatives Irony

hishamco commented 4 months ago

I notice that there's an issue with Irony.Core, so let us change the packages

@Skrypt what about NEST?

hishamco commented 4 months ago

FYI the Irony.Core has been replaced with Irony in #16012

hishamco commented 3 months ago

@Skrypt still waiting for your reply

Skrypt commented 3 months ago

No we can't replace NEST with the new Elasticsearch client without refactoring some parts of the Elasticsearch module. It will also remove support to some older versions of Elasticsearch so I see this upgrade as an OC.Elasticsearch 2.0 module. Meaning, we would need to keep the old module for those who want to still have support to older versions of Elasticsearch.

We launched the ES module when that new Elastic.Clients.Elasticsearch module was released so it should be around a year and a half that this new module exists. I think it adds support for ES 8.0 and up. NEST supports up to 8.0 in compatibility mode only.