search

OrchardCMS / OrchardCore

Orchard Core is an open-source modular and multi-tenant application framework built with ASP.NET Core, and a content management system (CMS) built on top of that framework.
https://orchardcore.net
BSD 3-Clause "New" or "Revised" License
7.31k stars 2.36k forks source link

Generalize options editor #16256

Open xnavrat4 opened 2 months ago

xnavrat4 commented 2 months ago

Is your feature request related to a problem? Please describe.

I wanted to reuse options editor for a custom TextField editor. While doing this, I noticed that while the optionsEditor.js's initializeOptionsEditor function offers a lot of parameters, the template id is hardcoded to #options-table. This makes it difficult to use fot other textfield editors.

Describe the solution you'd like

add id parameter to the initializeOptionsEditor funcion.

Does it seem reasonable? Thanks for considering it.

github-actions[bot] commented 2 months ago

Thank you for submitting your first issue, awesome! 🚀 We're thrilled to receive your input. If you haven't completed the template yet, please take a moment to do so. This ensures that we fully understand your feature request or bug report. A core team member will review your issue and get back to you.

If you like Orchard Core, please star our repo and join our community channels.

Piedone commented 2 months ago

This doesn't seem like a big deal to implement, but I'm curious, what kind of custom editor do you have, exactly? Since that script is specific to localization options.

sebastienros commented 2 months ago

Feel free to create a PR that does it to the actual source file: https://github.com/OrchardCMS/OrchardCore/blob/main/src/OrchardCore.Modules/OrchardCore.Localization/Assets/js/optionsEditor.js

github-actions[bot] commented 2 months ago

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.