search

OrchardCMS / OrchardCore

Orchard Core is an open-source modular and multi-tenant application framework built with ASP.NET Core, and a content management system (CMS) built on top of that framework.
https://orchardcore.net
BSD 3-Clause "New" or "Revised" License
7.34k stars 2.37k forks source link

Remove Media files for a removed tenant when using AWS S3 #16404

Open Piedone opened 2 months ago

Piedone commented 2 months ago

Is your feature request related to a problem? Please describe.

If you remove a tenant, its Media files are only removed if they use the default local storage in App_Data. When using AWS S3 though, they remain.

Similar to https://github.com/OrchardCMS/OrchardCore/issues/16403.

Describe the solution you'd like

Add an IShellRemovingHandler to OrchardCore.Media.AmazonS3 that removes Media files from S3 too. This should support both removing the whole bucket if tenants' Media are stored in separate buckets, or just the "folder" if a single container is used.

Describe alternatives you've considered

You can also have a custom IShellRemovingHandler implementation for this, but I think this should be a core functionality.

github-actions[bot] commented 1 month ago

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.