search

OrchardCMS / OrchardCore

Orchard Core is an open-source modular and multi-tenant application framework built with ASP.NET Core, and a content management system (CMS) built on top of that framework.
https://orchardcore.net
BSD 3-Clause "New" or "Revised" License
7.42k stars 2.39k forks source link

Refactor Culture and supported_cultures #16675

Open sebastienros opened 1 month ago

sebastienros commented 1 month ago

In this PR https://github.com/OrchardCMS/OrchardCore/pull/16208

  1. Culture was introduced to represent the selected culture for the context. We should just be able to return a new ObjectValue with the current culture in it and not have to proxy every property since CultureInfo is already registered.
  2. supported_cultures should not be a filter, because it's not using the input. We could pass anything to it and it would still work. I suggest we register a FluidValue like SupportedCultures so we can write for cultures in SupportedCultures.
  3. We should find a better way or improve Fluid to be able to register values and resolve its properties with lambdas. Instead of creating a XXXFluidAccessor then register it, like Environment, Culture, ...
github-actions[bot] commented 1 month ago

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.