search

OrchardCMS / OrchardCore

Orchard Core is an open-source modular and multi-tenant application framework built with ASP.NET Core, and a content management system (CMS) built on top of that framework.
https://orchardcore.net
BSD 3-Clause "New" or "Revised" License
7.44k stars 2.4k forks source link

In Auto setup, when IsUninitialized, response http status code 409 #16833

Open infofromca opened 1 month ago

infofromca commented 1 month ago

Describe the bug

In Auto setup, when IsUninitialized, response http status code 409 to let user know the error clearly.

Orchard Core version

2.0 Add the version of the Orchard Core NuGet packages you use, or the commit hash if you can reproduce this with the source code.

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'AutoSetup' when IsUninitialized
  2. See error
  3. httpContext.Response.Redirect(pathBase); will make the users to think the site got success.

Expected behavior

A clear and concise description of what you expected to happen. return status code 409

Logs and screenshots

If applicable, add log files, browser console logs, and screenshots (or screen recording videos) to help explain your problem.

github-actions[bot] commented 1 month ago

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

gvkries commented 1 month ago

The correct status code would be 503.