search

OrchardCMS / OrchardCore

Orchard Core is an open-source modular and multi-tenant application framework built with ASP.NET Core, and a content management system (CMS) built on top of that framework.
https://orchardcore.net
BSD 3-Clause "New" or "Revised" License
7.45k stars 2.41k forks source link

AssignRoleToUsers should not be implied by EditUsers #16954

Closed hishamco closed 1 day ago

hishamco commented 2 weeks ago

Fixes #16756

MikeAlhayek commented 2 weeks ago

@hishamco the issue is tagged with 3.0. It is probably better to work on these issues when we are getting ready to release 3.0 to avoid conflicts and extra work

hishamco commented 2 weeks ago

To be honest I'm not sure what is the roadmap, I think we should make this clear to everyone on the team

MikeAlhayek commented 2 weeks ago

The issue is assigned to 3.0 milestones. That means it won't be merged in 2.x.

hishamco commented 2 weeks ago

I changed it to 2.1.0

MikeAlhayek commented 2 weeks ago

You can't change it. It's a breaking change. That's why it was tagged with 3.0.

hishamco commented 2 weeks ago

While it's a bug we need to fix, this is a behavior breaking-change, I remembered we avoid code breaking-changes

MikeAlhayek commented 2 weeks ago

its not a bug and has been like this for a long time. But we should not need that EditUsers permissions there.

MikeAlhayek commented 4 days ago

@hishamco please document this change into 3.0.0 release notes and we'll merge it.