OrchardCMS / OrchardCore

Orchard Core is an open-source modular and multi-tenant application framework built with ASP.NET Core, and a content management system (CMS) built on top of that framework.
https://orchardcore.net
BSD 3-Clause "New" or "Revised" License
7.45k stars 2.4k forks source link

Improve Liquid Culture accessor #16956

Closed hishamco closed 2 weeks ago

hishamco commented 2 weeks ago

Fixes #16957

sebastienros commented 2 weeks ago

Working:

Culture: {{ Culture }} <br/>
Culture.Name: {{ Culture.Name }} <br/>
Culture == "en-US": {{ Culture == "en-US" }} <br/>
Culture == "en-EN": {{ Culture == "en-EN" }} <br/>
Culture.Dir: {{ Culture.Dir }} <br/>
Culture.DisplayName: {{ Culture.DisplayName }} <br/>
Culture.NativeName: {{ Culture.NativeName }} <br/>
Culture.TwoLetterISOLanguageName: {{ Culture.TwoLetterISOLanguageName }} <br/>

image

hishamco commented 2 weeks ago

Looks good, something I might not aware about in the past I thought the Scope.SetValue sets a value for each user

hishamco commented 2 weeks ago

Anything else or shall we merge it, coz I need to rid of the SupportedCultures filter in the next PR

sebastienros commented 2 weeks ago

sets a value for each user

In this case for each tenant. If you put a breaking it should be hit once.