Fix JSON parsing errors caused by spaces and special characters in Lu…

OrchardCMS / OrchardCore

Orchard Core is an open-source modular and multi-tenant application framework built with ASP.NET Core, and a content management system (CMS) built on top of that framework.

https://orchardcore.net

BSD 3-Clause "New" or "Revised" License

7.45k stars 2.4k forks source link

Fix JSON parsing errors caused by spaces and special characters in Lu… #16981

Closed emrahtokalak closed 1 week ago

emrahtokalak commented 1 week ago

Fix JSON parsing errors caused by spaces and special characters in LuceneQuerySource

Resolved issues with JSON parsing in LuceneQuerySource where spaces and special characters like / were causing errors.
Updated the parameterizedQuery parsing logic to handle these cases correctly.

As we can see from the following Lucene query, if there are liquid expressions within the template, it causes spaces in the JSON, leading to errors.

hishamco commented 1 week ago

Could you please add a unit test?

hishamco commented 1 week ago

@MikeAlhayek do you have anything else to add here?

MikeAlhayek commented 1 week ago

LGTM