search

OrchardCMS / OrchardCore

Orchard Core is an open-source modular and multi-tenant application framework built with ASP.NET Core, and a content management system (CMS) built on top of that framework.
https://orchardcore.net
BSD 3-Clause "New" or "Revised" License
7.45k stars 2.41k forks source link

Remove unnecessary WriteTo() in FludiValue subclasses #17008

Closed hishamco closed 1 week ago

MikeAlhayek commented 1 week ago

@hishamco why was this merged without an approval? You were one of the biggest advocates to not merging PR without approvals.

This is likely a breaking change and should not not be part of the 2.x release. You could mark these useless methods as obsolete meanwhile and remove them in v3.

hishamco commented 1 week ago

@hishamco why was this merged without an approval? You were one of the biggest advocates to not merging PR without approvals.

You are right on this, but Seb almost time busy :) and I'm afraid that you publish a release because at the time I can't remove anything until 3.0

@MikeAlhayek I just added this recently, so there are no breaking changes, just removing unnecessary overload

Related to https://github.com/sebastienros/fluid/pull/711

MikeAlhayek commented 1 week ago

It is still a binary breaking change and should not be taking in 2.x

hishamco commented 1 week ago

Why it's a binary-breaking change. As I mentioned earlier it wasn't there in the previous releases