search

OrchardCMS / OrchardCore

Orchard Core is an open-source modular and multi-tenant application framework built with ASP.NET Core, and a content management system (CMS) built on top of that framework.
https://orchardcore.net
BSD 3-Clause "New" or "Revised" License
7.45k stars 2.4k forks source link

Move OrchardCore.Translations.All #17036

Open Skrypt opened 3 days ago

Skrypt commented 3 days ago

To OrchardCore.Application.Cms.Core.Targets

Fixes #17035

sebastienros commented 2 days ago

Should we split Translation.All in two such that Core can reference core module translations, and .All include Cms modules too?

Skrypt commented 1 day ago

@sebastienros That would be even better.

Translation.Core.All Translation.CMS.All

Though, the thing is that currently the OrchardCore.Application.Cms.Targets is only there for including OC themes to the OrchardCore.Cms.Web project.

We would need to split translations for CMS modules vs Core Modules. Then have 3 or 4 .targets projects to included them all separately. I'm not sure if we have everything splitted up with Core and Modules. That may cause some issues of missing translations in the beginning.

Here, I remember that we set the Translations.All in the Cms.Target because we wanted to make the main one to be lightweight but that doesn't make sense to have modules that can be translated without having translations. We end up adding the reference to our web project. And it doesn't follow the same version as the current one which can lead to forgetting upgrading it along with the OC version.

hishamco commented 1 day ago

I think the main issue here is that we include all the translations even if we didn't use them, what if we include them on demand?

I saw some CMS load the translations on the fly, but while we don't have this capability we could install them using dotnet CLI