search

OrchardCMS / OrchardCore

Orchard Core is an open-source modular and multi-tenant application framework built with ASP.NET Core, and a content management system (CMS) built on top of that framework.
https://orchardcore.net
BSD 3-Clause "New" or "Revised" License
7.45k stars 2.4k forks source link

Release 2.1 #17039

Closed MikeAlhayek closed 21 hours ago

MikeAlhayek commented 2 days ago

Fix #16995

hishamco commented 2 days ago

Seems you didn't see my comment 5 days ago https://github.com/OrchardCMS/OrchardCore/issues/16995#issuecomment-2477156518

MikeAlhayek commented 2 days ago

Seems you didn't see my comment 5 days ago https://github.com/OrchardCMS/OrchardCore/issues/16995#issuecomment-2477156518

I did not.

MikeAlhayek commented 1 day ago

@sebastienros I think next steps are as follow:

  1. Release translation package on nuget.
  2. Update the package from nuget instead of cloud-smith.
  3. Merge main to release/2.1
  4. Merge releasel/2.1 on main
  5. Ship 2.1.

Do you see an issue with this?

sebastienros commented 1 day ago

I published the 2.1.0 translations packages.

MikeAlhayek commented 1 day ago

I published the 2.1.0 translations packages.

@sebastienros I updated the PR to use the 2.1.0. Let me know if you agree with the following steps next:

hishamco commented 1 day ago

@MikeAlhayek please hold on to this, there's a reported issue in Po Extractor https://github.com/OrchardCoreContrib/OrchardCoreContrib.PoExtractor/issues/100

@agriffard did you see such an error before, if nothing stopper we can ship OC 2.1, otherwise I will publish a patch release ASAP

agriffard commented 1 day ago

@MikeAlhayek please hold on to this, there's a reported issue in Po Extractor OrchardCoreContrib/OrchardCoreContrib.PoExtractor#100

@agriffard did you see such an error before, if nothing stopper we can ship OC 2.1, otherwise I will publish a patch release ASAP

I didn't have any error to update the .pot translation files.

sebastienros commented 1 day ago

Any PRs merged in translations looked good. Only issue could be that we missed some strings.

MikeAlhayek commented 21 hours ago

@hishamco that issue isn't impacting us per @sebastienros and @agriffard. We'll be shipping soon.

hishamco commented 21 hours ago

I replied to you on WhatsApp, but there's no respond from the author, so I can't reproduce the issue. Feel free to go