Move culture helpers to OrchardCore.Localization

OrchardCMS / OrchardCore

Orchard Core is an open-source modular and multi-tenant application framework built with ASP.NET Core, and a content management system (CMS) built on top of that framework.

https://orchardcore.net

BSD 3-Clause "New" or "Revised" License

7.23k stars 2.34k forks source link

Move culture helpers to OrchardCore.Localization #2895

Open hishamco opened 5 years ago

hishamco commented 5 years ago

For consistency and clarity, it would be nice to move the CultureDir(IOrchardHelper) and Culturename(IOrchardHelper) into localization assembly

sebastienros commented 5 years ago

Doesn't really matter. If more than one person thinks it's better then we can do it.

hishamco commented 5 years ago

IMHO it's localization related extension, one more thing I would like to add, it would be nice if we build a TagHelperComponent that uses CultureDir(IOrchardHelper) which sets the document's direction, this is super useful in case we support RTL languages such as Arabic, Hebrew and Persian