search

OrchardCMS / OrchardCore

Orchard Core is an open-source modular and multi-tenant application framework built with ASP.NET Core, and a content management system (CMS) built on top of that framework.
https://orchardcore.net
BSD 3-Clause "New" or "Revised" License
7.37k stars 2.38k forks source link

Upload theme and module from admin menu #3011

Closed khoshroomahdi closed 4 months ago

khoshroomahdi commented 5 years ago

I couldnt find any option to upload costume module and theme to orchard core in admin menu.

Skrypt commented 5 years ago

This option has been deprecated in Orchard Core since it would require loading/unloading assemblies dynamically. It needs to be re-evaluated when .net core 3.0 will be out since it introduces a way to unload assemblies at runtime. I think we can close this issue since it's a duplicate.

sebastienros commented 5 years ago

We expect to be able to support that for themes only, that would only contain static files (js, css, images, liquid templates).

khoshroomahdi commented 5 years ago

What about module? As i know in nopcommerce that based on netcore user allowed to upload theme and module

Skrypt commented 5 years ago

In NopCommerce they allow uploading themes and modules ; but you can't update a module on runtime without restarting the app pool because you can't unload an assembly on runtime. You can also uninstall a module which will cause the app pool to restart. Also, updating/uninstalling a module on runtime can cause service interruptions or delay since you are going to sometimes apply migrations to your data.

The ideal approach, right now, for updating your websites is using docker containers and swapping them. I think this is the best option there is and that explains also why this feature has been deprecated and is not a priority. I think no one is against the idea to reintroduce this feature once we will be able to unload assemblies on runtime... though first iterations will be really experimental.

Also, if we reintroduce this feature it will lead into needing a Module Gallery ... The dev focus right now is on shipping OC beta 3 and after that RC. There's a lot of dev remaining just there.

If you need such feature for yourself you can look in PR's there's been some attempts already on doing such thing which I'm really against since all you need is to learn how to use Docker 😉