search

OrchardCMS / OrchardCore

Orchard Core is an open-source modular and multi-tenant application framework built with ASP.NET Core, and a content management system (CMS) built on top of that framework.
https://orchardcore.net
BSD 3-Clause "New" or "Revised" License
7.4k stars 2.39k forks source link

ContentCulturePicker should respect the admin culture #5234

Open hishamco opened 4 years ago

hishamco commented 4 years ago

While I'm working on #5207 I notice that CCP is overriding the admin culture, because it uses the default localization cookie

Me as site admin the behavior is unexpected at all, coz whenever a user is change the culture on the site it will reflect immediately on the admin site, which is annoying

I think we already discussed before if we can provide a way to control the admin culture, for now IMHO we should use another cookie to track the user culture, so it will not affect the admins at all

Also I will think again for alternative solutions

/cc @sebastienros @jptissot your thoughts

hishamco commented 4 years ago

@jtkech I forgot to ping you, you already did cool things in localization ;)

jtkech commented 4 years ago

Okay cool

jtkech commented 4 years ago

Yes, just to confirm the behavior, if i select an item in a given culture through the CCP in the front end, then when i go back to the admin there is no more my french translations.

But maybe intended, and through the admin settings there is a culture picker option to not set this cookie.

hishamco commented 4 years ago

I'm ready to push a PR after I heard the feedback from Seb

hishamco commented 4 years ago

@sebastienros what's the action suggested for this item?