search

OrchardCMS / OrchardCore

Orchard Core is an open-source modular and multi-tenant application framework built with ASP.NET Core, and a content management system (CMS) built on top of that framework.
https://orchardcore.net
BSD 3-Clause "New" or "Revised" License
7.41k stars 2.39k forks source link

Shortcode Templates Feature needs deployment plans and recipes #7270

Closed deanmarcussen closed 3 years ago

deanmarcussen commented 4 years ago

Appears to have been forgotten todo

hishamco commented 4 years ago

@agriffard could please add it to the TODOs list that you did long time back, I may handle this if Dean don't mind

agriffard commented 4 years ago

Added to #5558

deanmarcussen commented 4 years ago

@hishamco if are are going to do this please base them off the Templates steps and deployment plans

agriffard commented 3 years ago

@hishamco Still todo, if you have some time that would help us.

hishamco commented 3 years ago

Hopefully I will start on this today or tomorrow, thanks for your reminder

hishamco commented 3 years ago

What should the shortcode recipe have, and what should be deployed?

deanmarcussen commented 3 years ago

@hishamco if are are going to do this please base them off the Templates steps and deployment plans

Just copy the templates recipe and deployment steps

hishamco commented 3 years ago

AFAIK I know a recipe should be created with 3 templates, in case of Roles the names are deployed, that's why I asked and sorry if I miss understand you

agriffard commented 3 years ago

Did you manage to progres on this one @hishamco ?

hishamco commented 3 years ago

I started on this a week ago, but I blocked, that's why I asked before, what should deployed in case of shortcodes

deanmarcussen commented 3 years ago

@hishamco if are are going to do this please base them off the Templates steps and deployment plans

Just copy the templates recipe and deployment steps.

I don't understand what is blocking you @hishamco all you need to do for this is the above.

hishamco commented 3 years ago

Seems I was looking for something to export, I just find ShortcodeTemplatesManager which the thing that I'm looking for, PR will be pushed soon ...