Admin Dark mode - Githubissues

OrchardCMS / OrchardCore

Orchard Core is an open-source modular and multi-tenant application framework built with ASP.NET Core, and a content management system (CMS) built on top of that framework.

https://orchardcore.net

BSD 3-Clause "New" or "Revised" License

7.43k stars 2.4k forks source link

Admin Dark mode #7402

Closed agriffard closed 4 years ago

agriffard commented 4 years ago

There are some incorrect displays when you are in Admin Dark mode:

nav with css class='admin-toolbar' have a light background.
List of admin menus has a light background and the type of menu is not displayed because it is in black:
Text in input-group is not displayed. Ex: Permalink in Create Sitemap or Autoroute:
Readonly input is grey on grey bg. Ex: Technical name in Edit Content type, Edit Layer:
Font picker icons are not displayed:

jptissot commented 4 years ago

Non dark mode issue

Skrypt commented 4 years ago

Look at the Bootswatch file which adds some unnecessary styles I think. That must be the issue with the default admin theme at least. Other ones are adjustments. Pokemon catch em' all ... too much of them.

hishamco commented 4 years ago

I think we need to revise the dark theme for all the pages before we merge this PR

Skrypt commented 4 years ago

Nahh, the feature is merged already. The intent was not to have it perfect on first try but to have the proper foundation to achieve it. As much time I put on this I can't find all the small issues but I believe it is functional for the most part. If you find an issue report it and I will fix it and merge PR as they are reported for everyone to have it quick.

hishamco commented 4 years ago

I can help you on fixing this too

Skrypt commented 4 years ago

Let me handle this. Thanks for the offer. I think you have some other remaining PR's that you can work on 😉

hishamco commented 4 years ago

Ya ;)