OrchardCMS / OrchardCore

Orchard Core is an open-source modular and multi-tenant application framework built with ASP.NET Core, and a content management system (CMS) built on top of that framework.
https://orchardcore.net
BSD 3-Clause "New" or "Revised" License
7.43k stars 2.4k forks source link

Update Markdown editor to the latest version of EasyMDE #7881

Closed aaronamm closed 3 years ago

aaronamm commented 3 years ago

For a WYSIWYG markdown editor, we use a fork of SimpleMDE and I think the author has renamed the project to EasyMDE. If you navigate URL https://github.com/ionaru/simplemde-markdown-editor, you will be redirected to https://github.com/Ionaru/easy-markdown-editor.

I think we should update this script to the latest version of EasyMDE which is 2.13.0 and use it from NPM package reference https://www.npmjs.com/package/easymde.

Here are what I think:

If you agree with the idea, I am happy to create a new PR for this.

However, this PR is blocked by https://github.com/OrchardCMS/OrchardCore/issues/7625 but it can bed started right away and fix a merge conflict later.

Thanks.

agriffard commented 3 years ago

Yes, you can create a PR. I don't mind changing to this library because it seems to be a fork that is more maintained and has a npm repo. Please use Assets.json and ResourceManifest (and add the version into the docs).

agriffard commented 3 years ago

We need of course the same plugins: Image and Shortcodes modals.

aaronamm commented 3 years ago

@agriffard Thank you for your reply and suggestion. I will use Assets.json and ResourceManifest.