search

OrchardCMS / OrchardDoc

Documentation for Orchard 1.x (not Orchard Core, for that see https://docs.orchardcore.net/).
http://docs.orchardproject.net
142 stars 241 forks source link

Improvements to contributors page #129

Closed rtpHarry closed 9 years ago

rtpHarry commented 9 years ago

The contributors page wasn't loading the gravatar urls (feed wasn't providing them) and it didn't have any real formatting applied.

Design Changes

Current design: image Proposed design: image

I wanted to get the full name of the developer in the h4 tag but after consulting the documentation the only way I could see to pull it in was to query the api for each contributor. I didn't do that as it seemed like overkill.

Licensing Considerations

I used a small snippet of Bootstrap 3 markup which is licensed under the MIT License:

Key elements

Permission is hereby granted, free of charge...to use, copy, modify, merge...subject to the following conditions:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

I used approximately 50 lines of the css code (and some of that could be trimmed down to be honest). My personal feeling is that this doesn't qualify as a "substantial portion" of the software so I don't think its an issue.

abhishekluv commented 9 years ago

Thanks @rtpHarry

abhishekluv commented 9 years ago

@rtpHarry How about linking the image to the contributors github profile.

rtpHarry commented 9 years ago

good point, I've made a pull request for it

abhishekluv commented 9 years ago

@rtpHarry Thanks! Merged.